Feat Regenerate invoice from voided invoice #3992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf7d621 to
8a1a81d
Compare
c3ba468 to
c7bae65
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables the regeneration of voided invoices with adjusted fee attributes. The feature allows users to correct or adjust values like units, unit_amount_cents, or invoice_display_name after an invoice has been voided.
- Introduces
AdjustedFees::EstimateServicefor previewing fee adjustments without persistence - Adds
Invoices::RegenerateFromVoidedServicefor rebuilding invoices from voided ones with adjustments - Establishes relationships between original and regenerated invoices via
voided_invoice_idfield
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
app/services/adjusted_fees/estimate_service.rb |
New service for calculating adjusted fee estimates |
app/services/invoices/regenerate_from_voided_service.rb |
Core service for regenerating invoices from voided ones |
app/graphql/mutations/adjusted_fees/preview.rb |
GraphQL mutation for previewing adjusted fees |
app/graphql/mutations/invoices/regenerate_from_voided.rb |
GraphQL mutation for regenerating invoices |
app/models/invoice.rb |
Adds association to track regenerated invoices |
app/services/invoices/create_one_off_service.rb |
Adds support for voided_invoice_id parameter |
| Various GraphQL types and schema files | Adds new input types and fields for the feature |
| Spec files | Comprehensive test coverage for new services and mutations |
lovrocolic
reviewed
Aug 6, 2025
lovrocolic
reviewed
Aug 6, 2025
lovrocolic
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when voiding an invoice, it’s not possible to regenerate it with updated fee attributes. This limitation creates friction for users who want to correct or adjust values such as units, unit_amount_cents, or invoice_display_name after an invoice has already been issued and voided.
Description
This PR introduces two new services that enable the regeneration of a voided invoice with adjusted fee values:
AdjustedFees::EstimateService
This service is used to preview how a fee would be adjusted before persisting any data. It handles all necessary backend calculations—such as tax application, amount breakdown, and unit price derivation—based on the provided input. It is designed to be used by the frontend to fetch real-time estimates while the user is making adjustments to fees.
Invoices::RegenerateFromVoidedService
This service is responsible for actually rebuilding the invoice from a voided one. It:
• Duplicates relevant fee records,
• Applies adjustments coming from the frontend (e.g., new units, updated unit_amount_cents, or invoice_display_name),
• Recalculates all fee amounts, taxes, and totals,
• Applies coupons, credit notes, and prepaid credits if applicable,
• Transitions the invoice to the appropriate payment status (pending or succeeded).