Skip to content

feat(wallet-limitations): Add service updates for billable metric wallet limitation #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2025

Conversation

lovrocolic
Copy link
Collaborator

Context

With this feature it will be possible to limit wallet consumption on specific billable metric fees

Description

This PR adds needed changes in create and update services for wallets. Billable metric identifiers are processed so that codes are used form the api side and ids are used from the GQL side. Each billable metric limitation per wallet results in new WalletTarget object

@lovrocolic lovrocolic marked this pull request as ready for review July 11, 2025 10:35
@lovrocolic lovrocolic force-pushed the feat-wallet-limit-bm branch 3 times, most recently from befcaf8 to 026a03b Compare July 24, 2025 13:38
Copy link
Contributor

@floganz floganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!
I left few nit-picks but It's totally OK to skip them.

…ions (#3979)

## Context

With this feature it will be possible to limit wallet consumption on
specific billable metric fees

## Description

This PR adds graphQL support for billable metrics that should be
targeted by wallet credits
…ion (#3978)

## Context

With this feature it will be possible to limit wallet consumption on
specific billable metric fees

## Description

This PR adds api support for billable metrics that should be targeted by
wallet credits
@lovrocolic lovrocolic force-pushed the feat-wallet-limit-bm branch from 3d86ca7 to 8835f8e Compare July 25, 2025 08:23
@lovrocolic lovrocolic merged commit 709b75b into main Jul 25, 2025
14 checks passed
@lovrocolic lovrocolic deleted the feat-wallet-limit-bm branch July 25, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants