fix(netsuite): Do not create duplicate contacts in netsuite #3801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An edge case might occur when there's already a contact created in Netsuite but there's also another job that is trying to create the same contact. In that case another contact in netsuite was created (with new external_id) but then the job failed when trying to save the duplicate in the DB
Description
This PR fixes creating duplicate contacts in
IntegrationCustomers::NetsuiteServiceby first checking if the record exists inintegration_customerstable in which case it doesn't even call the nango endpoint and returns the existing integration customer.