fix: Use current attributes instead of activejob_traceable #3794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we've seen that our current use of
activejob_traceable
is not thread safe with Sidekiq 😢With the addition of activity logs, we've seen that
CurrentContext
can use wrong information (membership_id
andsource
) because we're not resetting values at the start of each job. Two jobs can sequentially run on the same thread.The goal of this PR is to not use
activejob_traceable
anymore (and remove a dependency 🎉 ), but introduceActiveSupport::CurrentAttributes
in Sidekiq jobs.This middleware allows to:
CurrentContext
into the Sidekiq job