feat(stripe): Introduce integration tests (calling Stripe API) #3783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b1a674 to
5548892
Compare
2025-04-30.basil2025-04-30.basil
5548892 to
942e8d4
Compare
2025-04-30.basil
diegocharles
reviewed
Jun 5, 2025
diegocharles
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
@julienbourdeau The code looks great man!
I just left optional suggestions to use the dig method instead of nested keys if you agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the stripe upgrade, I added integration tests to call the Stripe API for real.
By default, it still runs
2020-08-27version but locally you can run the future version by setting the version in youapi/.envThe integration tests are not run on CI. You must run them locally.