feat(alerting): new field for alert.triggered webhook payload #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
approved these changes
Jun 4, 2025
groyoh
reviewed
Jun 4, 2025
Comment on lines
+68
to
+72
| current_value: 51, | ||
| previous_value: 8, | ||
| crossed_thresholds: [ | ||
| {code: nil, value: 10, recurring: false}, {code: :warn, value: 25, recurring: false}, {code: :alert, value: 50, recurring: false} | ||
| ], |
There was a problem hiding this comment.
Do those values make sense given that it doesn't match the actual alert thresholds ?
thresholds: [
{code: "info", value: 1000_00}
]
Or did I miss something ?
There was a problem hiding this comment.
Good question! It doesn't with the current state of the alert.
When alerts are updated, we replace (delete_all + insert) all thresholds. That why we store the threshold fully and don't "link to the threshold_id". We can assume this alert was set up this way 2 months ago and updated later.
The threshold make sense with the previous_value / current_value tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm documenting this
alert.triggeredwebhook I realize there was some field that could be better.subscription_external_idis how you can retrieve subscription via the API (instead of lago_id)organization_idin case you receive webhooks from multiple organizations? It should be everywhere.I also edited the seeder to seed some TriggeredAlert.