fix: use keyword arguments when calling refresh draft job #3778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
reviewed
Jun 3, 2025
| @@ -12,7 +12,7 @@ class RefreshDraftJob < ApplicationJob | |||
|
|
|||
| unique :until_executed, on_conflict: :log, lock_ttl: 12.hours | |||
|
|
|||
| def perform(invoice) | |||
| def perform(invoice:) | |||
There was a problem hiding this comment.
Isn't there a risk of introducing a minor breaking change (during the deployment) with this change ? If clock gets deployed before worker and the job runs, it would serialize the argument as keyword args and the running worker code would still expect a global id. This could lead to some dead jobs until worker finish deploying.
There was a problem hiding this comment.
I would say it should be fine. Even if we end up with some dead jobs (which is low probability), this job is safe to run multiple times and we can re-run it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It seems that AR deserialisation in jobs does not work sometimes in combination with uniqueness constraint
Description
After investigation, seems that preferred approach is switching to keyword arguments which are handled a bit different during deserialisation