feat (wallet-credit-limitations): Add precise credit notes calculation per fee #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
approved these changes
Jun 2, 2025
d102233 to
fd14073
Compare
fd14073 to
c9b8b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently wallet credits are applied on all fee types. This feature adds possibility to limit wallet consumption on specific fee type.
Description
This PR adds
precise_credit_notes_amount_centscolumn that is responsible for calculation of weighted credit note amount per fee.This information is needed to get the full
per feebreakdown of credits. Wallet credits with fee limitations cannot be applied correctly after the credit notes if this information is missing.