fix(invoice-preview): Support preview for subscription during upgrade or downgrade #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
reviewed
May 29, 2025
lovrocolic
reviewed
May 29, 2025
20eb1ac to
d7dace5
Compare
lovrocolic
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Current logic for invoice preview does not take into account if existing subscription is in the process of downgrade or upgrade. To generate proper invoice preview we need to slightly adjust data so that subscription state matches one of a new bill run.
Description
Add validation for customer persistence. It improves UX by providing more precise error message for some invalid params.
Add support for proper preview of subscription in a process of being downgraded.