-
Notifications
You must be signed in to change notification settings - Fork 126
feat: coupon recrediting when voiding invoices #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
e405732
to
aa948fa
Compare
vincent-pochet
approved these changes
May 27, 2025
julienbourdeau
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
diegocharles
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When an invoice is voided, any applied coupons associated with that invoice should be properly recredited. Previously, when an invoice was voided, the credits from applied coupons were not properly handled, which could lead to customers losing coupon benefits they were entitled to. This was particularly problematic for recurring coupons and coupons with a limited number of uses.
Description
This PR implements a comprehensive solution for handling coupon credits when invoices are voided:
Added active and voided scopes to filter credits based on invoice status
These scopes ensure that only credits from non-voided invoices are counted against the coupon's remaining amount
Added AppliedCoupons::RecreditService:
Implemented a new service that handles recrediting of applied coupons when an invoice is voided
For terminated coupons: reactivates the coupon if it was terminated due to usage, and the original coupon is still active
For recurring coupons: increments the frequency_duration_remaining to restore the usage count
Uses database locking to prevent race conditions during concurrent operations