Skip to content

feat(multientities): applied_dunning_campaign on BE to follow org #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 6, 2025
Merged

feat(multientities): applied_dunning_campaign on BE to follow org #3724

merged 11 commits into from
Jun 6, 2025

Conversation

annvelents
Copy link
Contributor

Context

We're switching dunning campaign definition to billing entity, but to do this, firstly we should support backward compatibility

Description

  • added a migration to populate billing_entity.applied_dunning_campaign_id
  • added a foreign key with validation on this reference
  • when creating / updating / discarding a dunning campaign, if it's applied on billing_entity, this relation also will be updated

annvelents
annvelents commented May 27, 2025
View reviewed changes
@annvelents annvelents marked this pull request as ready for review May 27, 2025 08:37
@annvelents annvelents force-pushed the feat/multientities/be_dunning_campaign-follow-org branch 6 times, most recently from f622bf6 to f2bc670 Compare May 27, 2025 09:37
ancorcruz
ancorcruz approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@annvelents annvelents force-pushed the feat/multientities/be_dunning_campaign-follow-org branch from 37bb156 to 20c407f Compare June 5, 2025 13:37
@annvelents annvelents force-pushed the feat/multientities/be_dunning_campaign-follow-org branch from 6b82440 to e469aa8 Compare June 5, 2025 13:43
@annvelents annvelents merged commit 749c742 into main Jun 6, 2025
14 checks passed
@annvelents annvelents deleted the feat/multientities/be_dunning_campaign-follow-org branch June 6, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancorcruz ancorcruz ancorcruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annvelents @ancorcruz