fix(daily-usage): Fix from and to dates in daily usages service #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the date range used when populating daily_usages to correctly use charge dates and adjusts the serializer to group and aggregate filter metrics.
- Switched
from_datetime/to_datetimetocharges_from_datetime/charges_to_datetimein the fill service. - Refactored
ChargeUsageSerializer#filtersto group fees by their filter attributes and sum units, amounts, and event counts. - Updated the serializer spec to expect aggregated totals over three identical fee entries.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| spec/serializers/v1/customers/charge_usage_serializer_spec.rb | Updated test setup to build three fee entries and check summed values. |
| app/services/daily_usages/fill_from_invoice_service.rb | Changed date fields to use charge-specific datetime attributes. |
| app/serializers/v1/customers/charge_usage_serializer.rb | Replaced sort-by map logic with grouping and aggregation. |
Comments suppressed due to low confidence (1)
spec/serializers/v1/customers/charge_usage_serializer_spec.rb:91
- The spec currently only verifies grouping for identical filters. Consider adding a test case with multiple distinct
charge_filtervalues to ensure the grouping and aggregation logic handles varied inputs correctly.
expect(result["charges"].first["filters"].first).to include(
vincent-pochet
approved these changes
May 26, 2025
0d5a21c to
73cbb72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that calculates usages and pre-fills
daily_usagestable: