Skip to content

Fix(wallet balance): failed transaction and voided invoice #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

Fix(wallet balance): failed transaction and voided invoice #3703

merged 4 commits into from
May 27, 2025

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented May 22, 2025 •
edited
Loading

Context

we got a bug where:

  1. a credit was purchased (1$)
  2. invoice marked as succeeded -> wallet transaction marked as settled,
  3. wallet balance is updated to 1$
  4. invoice payment status updated to failed -> wallet transaction marked as failed
  5. wallet balance WAS NOT updated (still 1$) - FIRST ISSUE
  6. invoice is voided -> recredit wallet_transaction is created - SECOND ISSUE
  7. wallet balance increases to 2$

Description

  • when fail a wallet transaction, if a transaction was settled before, it will stay settled, the credits should be voided manually
  • when recredit wallet_transactions when voiding an invoice, only recredit outbound wallet transaction (exactly "applied" credits from the wallet)

ancorcruz
ancorcruz reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in a call... settled wallet transactions should not be updated as failed, instead the WT should be voided and created a new WT to deduct the amount.

Another question is why a succeeded payment became failed?

@annvelents annvelents force-pushed the fix/failed-wallet-transaction-update-wallet branch from 4e4cdee to 690512d Compare May 23, 2025 13:06
@annvelents annvelents merged commit 4098769 into main May 27, 2025
14 checks passed
@annvelents annvelents deleted the fix/failed-wallet-transaction-update-wallet branch May 27, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancorcruz ancorcruz ancorcruz left review comments

@brunomiguelpinto brunomiguelpinto brunomiguelpinto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annvelents @ancorcruz @brunomiguelpinto