feat(alerting): Add LifetimeUsageAmount and BillableMetricUsageUnits alerts #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efe4a31 to
cf7033a
Compare
julienbourdeau
commented
May 21, 2025
julienbourdeau
commented
May 21, 2025
cf7033a to
1d1884f
Compare
floganz
reviewed
May 22, 2025
spec/models/usage_monitoring/lifetime_usage_amount_alert_spec.rb
Outdated
Show resolved
Hide resolved
spec/models/usage_monitoring/billable_metric_usage_units_alert_spec.rb
Outdated
Show resolved
Hide resolved
app/services/usage_monitoring/process_subscription_activity_service.rb
Outdated
Show resolved
Hide resolved
1d1884f to
dd08ab0
Compare
dd08ab0 to
a3ddf2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We're adding Alerting feature, see #3528, #3535, #3554, #3600
Description
We introducing 2 new types of alerts:
Creating a new alert is essentially creating a new child class of
UsageMonitoring::Alertand implementingfind_value. 🙌