Fix(wallet_transaction): Don't create transaction when the credits are zero or negative. #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ad03f4 to
6b1a9e3
Compare
app/services/wallets/create_interval_wallet_transactions_service.rb
Outdated
Show resolved
Hide resolved
6b1a9e3 to
9d4799a
Compare
9d4799a to
be7b947
Compare
app/services/wallets/create_interval_wallet_transactions_service.rb
Outdated
Show resolved
Hide resolved
brunomiguelpinto
approved these changes
May 23, 2025
…ng_balance is higher than Wallet ongoing balance Fix Rubocop offense Skip WalletTransaction when paid and granted credits are zero Only skip if recurring_rule is target? Fix method mistake
bce35c8 to
32f85ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create WalletTransaction if the paid_credits is zero or negative.