Skip to content

fix(estimate fees): return 1 unit for estimate count_aggr #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

annvelents
Copy link
Contributor

Context

when estimating instant fees, we're using a new service, and there we're assuming that amount of units is sent in the event, but some aggregation types do not contain units in properties, because we consider the whole event as unit

Description

  • If charge billable_metric does not support field name, we should consider the whole event as one unit
  • small additional fix: when generating progressive billing invoice, this process can fail because of idempotency, if it was triggered multiple times, so we don't want to send the webhook if the invoice generation failed

@annvelents annvelents changed the title fix(estimate fees): return 0 units for count_aggr fix(estimate fees): return 1 unit for estimate count_aggr May 21, 2025
@annvelents annvelents merged commit 092f60e into main May 22, 2025
14 checks passed
@annvelents annvelents deleted the fix/estimate-instant-fee branch May 22, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants