fix(multientities): wrong document numbering #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorcruz
requested changes
May 7, 2025
db/migrate/20250507110137_fix_billing_entity_document_numbering_prefix.rb
Outdated
Show resolved
Hide resolved
ancorcruz
approved these changes
May 8, 2025
ancorcruz
requested changes
May 8, 2025
db/migrate/20250507110137_fix_billing_entity_document_numbering_prefix.rb
Outdated
Show resolved
Hide resolved
ancorcruz
approved these changes
May 13, 2025
…g_prefix.rb Co-authored-by: Ancor Cruz <hello@ancorcruz.com>
b7a309b to
dccc29a
Compare
9f1940b to
dc53b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When creating billing entity per organization, we generate it's document number prefix the same way as we generate it for org: first 3 letters of name + last 3 letters of id. That's why when we create a first billing_entity per organization, it inherits org's ID.
But at some point we were not populating the id of billing entity, as result generated document_number_prefix was different from the organization (the id part).
Later billing_entities ids were fixed to always match organizations, but we didn't fix the document_number_prefix (on US cluster there are 4 orgs with this issue, 0 on EU).
This PR finds these BEs and fixes them
Description
Find default billing_entities per organizations, where billing_entity.documnet_number_prefix != organization.document_number_prefix and fix them to have org's document_number_prefix