Skip to content

Conversation

annvelents
Copy link
Contributor

Context

Since we're deprecating these fields on organization, we should be taking them from the default billing_entity when sending to the frontend.
The analytics still should collect data for different currencies, but on the FE they're sending us default currency of org to filter the values

Description

Redefined default_currency and timezone on org
changed the way we retrieve default_billing_entity to not have to reload the association

@annvelents annvelents marked this pull request as ready for review May 12, 2025 12:25
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks.

Base automatically changed from feat/multientities-6-update-invoice_net_term to main May 13, 2025 07:44
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@annvelents annvelents merged commit dd58119 into main May 13, 2025
10 checks passed
@annvelents annvelents deleted the feat/multientities-6-analytics-currency branch May 13, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants