Skip to content

Feat(multientities): refresh draft invoices when manage taxes on billing entity #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Apr 24, 2025

Context

Since we're deprecating applied_to_organization field on organization, the draft invoices should be refreshed when:

  • tax is updated on organization
  • tax is applied or removed on applied to billing_entity

Description

  • added refresh_draft_invoices method to all manage taxes on billing_entity services

@annvelents annvelents changed the base branch from main to feat/multientities-6-apply-taxes-on-invoices April 24, 2025 10:42
@annvelents annvelents force-pushed the feat/multientities-6-refresh-draft-invoices-when-apply-taxes branch from 184c374 to 38d8505 Compare April 24, 2025 10:54
@annvelents annvelents marked this pull request as ready for review April 24, 2025 12:25
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

I have left one comment applicable to all test changes...

Base automatically changed from feat/multientities-6-apply-taxes-on-invoices to main May 13, 2025 10:39
@annvelents annvelents force-pushed the feat/multientities-6-refresh-draft-invoices-when-apply-taxes branch from f120882 to d71504c Compare May 13, 2025 10:42
@annvelents annvelents merged commit e205911 into main May 13, 2025
14 checks passed
@annvelents annvelents deleted the feat/multientities-6-refresh-draft-invoices-when-apply-taxes branch May 13, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants