Skip to content

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Apr 23, 2025

Context

As now taxes are applied on billing entitites, this PR switches invoices generation with applied taxes taken from billing_entities to the taxes form the organization

Description

  • Switch the applied taxes definition
  • updated tax.applicable_customers method
  • updated tests to ignore applied_to_organization field on tax

@annvelents annvelents force-pushed the feat/multientities-6-apply-taxes-on-invoices branch 8 times, most recently from 2f27e14 to eb3e006 Compare April 24, 2025 08:51
@annvelents annvelents marked this pull request as ready for review April 24, 2025 08:55
@annvelents annvelents force-pushed the feat/multientities-6-apply-taxes-on-invoices branch from eb3e006 to ccc2ec6 Compare April 24, 2025 08:59
@annvelents annvelents changed the title Feat(multientities): use default taxes from selected for the billing entity Feat(multientities): use taxes from selected for the billing entity for invoices Apr 24, 2025
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just left a few comments.

@annvelents annvelents force-pushed the feat/multientities-6-apply-taxes-on-invoices branch from 0202620 to 6181f1d Compare May 12, 2025 10:42
@annvelents annvelents merged commit 9debab0 into main May 13, 2025
14 checks passed
@annvelents annvelents deleted the feat/multientities-6-apply-taxes-on-invoices branch May 13, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants