Skip to content

feat(stripe): Save payment_method_data for successful Payments #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

feat(stripe): Save payment_method_data for successful Payments #3230

merged 2 commits into from
Mar 3, 2025

Conversation

julienbourdeau
Copy link
Contributor

@julienbourdeau julienbourdeau commented Feb 20, 2025 •
edited
Loading

Description

With Stripe, save payment method details when the payment_intent.succeeded webhook is received.

{
  id: "pm_123",
  type: "card",
  last4: "4242", # only if type == card
  brand: "visa", # only if type == card
}

@julienbourdeau julienbourdeau self-assigned this Feb 20, 2025
vincent-pochet
vincent-pochet reviewed Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

Base automatically changed from feat/remove-charge-succeeded-webhook to main February 21, 2025 18:38
@julienbourdeau julienbourdeau force-pushed the feat/save-payment-method branch from dcbdece to 24d8300 Compare February 21, 2025 19:54
@julienbourdeau julienbourdeau marked this pull request as draft February 24, 2025 17:31
@julienbourdeau julienbourdeau force-pushed the feat/save-payment-method branch 2 times, most recently from 04504ff to baab3f1 Compare February 24, 2025 23:06
@julienbourdeau julienbourdeau marked this pull request as ready for review February 24, 2025 23:11
@julienbourdeau julienbourdeau force-pushed the feat/save-payment-method branch 2 times, most recently from dda3a58 to 24ddd19 Compare February 27, 2025 23:04
@julienbourdeau julienbourdeau mentioned this pull request Feb 27, 2025
Closed
@julienbourdeau
Copy link
Contributor Author

To be merged Monday.

I started adding support for Adyen but it's not as straight forward as expected: #3271

@julienbourdeau julienbourdeau force-pushed the feat/save-payment-method branch from 24ddd19 to 2dd109d Compare March 3, 2025 10:30
@julienbourdeau julienbourdeau merged commit 089ce76 into main Mar 3, 2025
6 checks passed
@julienbourdeau julienbourdeau deleted the feat/save-payment-method branch March 3, 2025 10:53
@julienbourdeau julienbourdeau mentioned this pull request Mar 6, 2025
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet left review comments

@ivannovosad ivannovosad ivannovosad approved these changes

Assignees

@julienbourdeau julienbourdeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienbourdeau @ivannovosad @vincent-pochet