fix(credit-notes): Prevent ArgumentError masking with proper reason validation
#4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation ## Context The service was catching all ArgumentError exceptions and converting them to reason validation errors, which could mask legitimate errors from other parts of the code. This made debugging difficult and could hide real bugs. ## Description - Add explicit reason validation using invalid_reason? method before model assignment - Validate reason against CreditNote.reasons.keys to ensure only valid enum values are accepted - Remove broad ArgumentError rescue that was silently converting any ArgumentError to reason validation failure - Add early validation return to prevent invalid reasons from reaching model assignment - Remove aggregate_failures from test cases for better test isolation - Add test case to verify proper error handling for invalid reason parameter
ArgumentError masking with proper reason validationArgumentError masking with proper reason validation
julienbourdeau
approved these changes
Aug 27, 2025
vincent-pochet
approved these changes
Aug 28, 2025
There was a problem hiding this comment.
Good catch, It's a good fix!
Have you also considered adding the validate: true to the reason enum?
It was introduce after the creation of the Credit Note feature and it has the advantage on relying on the standard rails validation that is already in place in this service.
The downside is that it could have some unexpected side-effects but it should be very limited.
Well, TIL about Thanks for the hint @vincent-pochet, I'll try and update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
CreditNote::Createservice was catching allArgumentErrorexceptions and converting them toreasonvalidation errors, which could mask legitimate errors from other parts of the code. This made debugging difficult and could hide real bugs.Description
This fixes the issue by adding an explicit validation.