misc(event): remove unique validation #4133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdenquin
approved these changes
Aug 12, 2025
95b5511 to
194a13c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR intend to improve the performance when creating an event using the
POST /api/v1/events.The event model has a uniqueness validation on the transaction_id field. Rails is performing a database query to validate this uniquess and it appears to be slow...
Description
Since we already have a unique index in place in the database, this PR removes the validation and adds the logic to catch the Postgres error.
Some load testing have been conducted with this approach and it cuts the response time by a large factor, increasing the number of events/sec that could be received by the API