misc: Add BillingPerdiodBoundaries #4121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
616cb53 to
2cfc909
Compare
2cfc909 to
5d115af
Compare
rsempe
reviewed
Aug 8, 2025
rsempe
reviewed
Aug 8, 2025
5d115af to
503b204
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In many places of the application, we are defining a
boundariesobject, sometimes as an instance of aHash, sometimes as anOpenStruct. The fields are not always the same and since the boundaries are injected in a lot of services, this causes some uncertainty when accessing the properties.Description
In an attempt to improve the readability and the reliability of this key part of the application, the goal of this PR is to introduce a new
BillingPeriodBoundariesclass and to use it everywhere in replacement ofHashandOpenStruct.It should also improve the memory consumption as OpenStructs are known to cause memory issues in Ruby when YJIT is enabled