feat: we need to grab charges even if deleted #4127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When an invoice is regenerated (voided_invoice_id present), the associated AdjustedFee can reference a Charge or ChargeFilter that has been soft-deleted.
Currently:
• adjusted_fee.charge returns nil for deleted charges because the association respects the default scope.
• adjusted_fee.charge_filter behaves similarly.
This causes missing data in regenerated invoices and prevents correct fee reconstruction.
Description
This PR updates the service and model layer to reliably fetch Charge and ChargeFilter for AdjustedFee records when working with regenerated invoices