Skip to content

Conversation

lovrocolic
Copy link
Collaborator

Context

Currently fees on one-off invoices does not contain billing period

Description

As part of the quotes feature, the decision is to add billing period on one-off invoice. This information would be consumed by analytics since it would allow splitting revenue across the billing interval

@ansmonjol ansmonjol force-pushed the one-off-billing-period branch from e3338d2 to 1bf0108 Compare August 11, 2025 11:37
@lovrocolic lovrocolic force-pushed the one-off-billing-period branch from 53b685d to 479bf1c Compare August 11, 2025 15:59
Copy link
Contributor

@floganz floganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please fix tests before merging it.

@lovrocolic lovrocolic force-pushed the one-off-billing-period branch from 479bf1c to 7dd1c95 Compare August 12, 2025 13:18
@lovrocolic lovrocolic merged commit 271fb54 into main Aug 12, 2025
14 checks passed
@lovrocolic lovrocolic deleted the one-off-billing-period branch August 12, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants