fix(activity-log): Do not include fees when there are too many of them #4102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
reviewed
Aug 6, 2025
rsempe
approved these changes
Aug 6, 2025
mariohd
approved these changes
Aug 6, 2025
a7b4976 to
c8f7fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is an issue when we're calling
ActivityLogwith a huge payload e.g. an invoice with a lot of fees.In that case we're hitting the Kafka payload limit (1MB by default) and getting
WaterDrop::Errors::MessageInvalidErrorDescription
In order to fix this issue we skip fees to be serialized for invoices that have more than 25 fees.
So that
ActivityLogwould still log the invoice except the fees in this case.