Feat(fixed_charges): Extract ChargeModel::FilterPropertiesService #4100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Roadmap Task 👉 https://getlago.canny.io/feature-requests/p/allow-add-ons-to-be-added-to-subscription-invoices 👉 https://getlago.canny.io/feature-requests/p/define-quantities-for-plan-charges ## Context What is the current situation? **Option 1:** User has to create a one off invoice alongside the subscription, it will create 2 different invoices. **Option 2:** User can add a recurring billable metric and use event to have this fee invoice on subscription renewal, but it won’t appear on the first billing subscription. What problem are we trying to solve? At subscription creation or afterward, there is no clear way to invoice a fixed fee that is not tied to events, aside from the subscription fee itself. This fee could be either a one-time charge or a recurring one. ## Description - Extract `FilterChargeModelPropertiesService` from `Charges` namespace to `ChargeModels` namespace. Also, ensure it supports different chargeable types like `charge` and `fixed_charge`
vincent-pochet
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/allow-add-ons-to-be-added-to-subscription-invoices
👉 https://getlago.canny.io/feature-requests/p/define-quantities-for-plan-charges
Context
What is the current situation?
Option 1: User has to create a one off invoice alongside the subscription, it will create 2 different invoices.
Option 2: User can add a recurring billable metric and use event to have this fee invoice on subscription renewal, but it won’t appear on the first billing subscription.
What problem are we trying to solve?
At subscription creation or afterward, there is no clear way to invoice a fixed fee that is not tied to events, aside from the subscription fee itself. This fee could be either a one-time charge or a recurring one.
Description
FilterChargeModelPropertiesServicefromChargesnamespace toChargeModelsnamespace. Also, ensure it supports different chargeable types likechargeandfixed_charge