fix(invoice-preview): Ensure that plan lookup uses only parent plans #4091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
417b233 to
44e6e86
Compare
lovrocolic
reviewed
Aug 4, 2025
lovrocolic
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When we look for a plan by
codeit possible to find children plan, which share the same code as parent. For invoice preview that creates an issue as it could pick up child plan which is not visible anywhere in the UI and be confusing for users when they got different values from visible parent plans.Description
Ensure that we look for a plan only within parent plans when using invoice preview feature.