Feat Allow multiple subscription_starting invoice_subscriptions when regenerating invoice #4083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
reviewed
Aug 1, 2025
db/migrate/20250731144632_add_scoped_index_to_starting_invoice_subscription.rb
Show resolved
Hide resolved
annvelents
reviewed
Aug 1, 2025
db/migrate/20250731145640_remove_old_starting_invoice_subscription_index.rb
Outdated
Show resolved
Hide resolved
annvelents
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To support regenerating invoices for starting subscriptions, we need to allow multiple
invoice_subscriptionsrecords with the samesubscription_idandinvoicing_reason = 'subscription_starting', as long as the invoice has been regenerated.Currently, the uniqueness constraint (
index_unique_starting_subscription_invoice) prevents this scenario, blocking valid regeneration flows for subscription starts.Description
These changes allow invoice regeneration logic to function properly for starting subscriptions, while preserving database integrity for non-regenerated records.