chore(gql): update plan entitlements directly in Plan update mutation #4068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
431bab1 to
e9ea1e3
Compare
5110fa6 to
892b18e
Compare
groyoh
approved these changes
Jul 25, 2025
app/services/entitlement/subscription_entitlements_update_service.rb
Outdated
Show resolved
Hide resolved
892b18e to
87d2ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow plan entitlements to be sent as part of the PlanInput object. I initially made it into a separate mutation.
I improved the value validation because sending valid data as string should be considered valid... and because this is how graphql send them 😄
Fixed the
::Entitlement::SubscriptionEntitlementsUpdateServicesince it wasn't used unpartial: falseyet.Add ability to modify subscriptions entitlements in the subscription update mutation.