-
Notifications
You must be signed in to change notification settings - Fork 126
Feat(fixed_charges-1): add fee model updates #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5c4cae
to
9ddc807
Compare
846895f
to
e845108
Compare
9ddc807
to
e8ddad9
Compare
brunomiguelpinto
approved these changes
Aug 1, 2025
ancorcruz
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5e4d6e0
to
2effb40
Compare
## Context As part of work on fixed charges, subscription will have many fixed_charges through plan and also many add_ons through fixed charges ## Description - updated subscription model - updated subscription model spec
Base automatically changed from
feat/fixed_charges-1/migration-update-fee
to
main
August 5, 2025 07:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As fee now can be related to a fixed_charge, items will be charge fee's addon, so a lot of item-related methods should be updated
Description