Security: refactor disk resource lookup logic #5666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Addresses
GHSA-c4qv-fm8g-wm67
With 184fd65 the changes are:
/
which isn’t really all that helpful.So again, the logic of matching a drive hasn’t changed, we still just pull the list of drives from systeminformation and match them against the drive requested in the config. If you are now seeing “not available” you were previously seeing the root
/
and just didn’t realize.A helpful tip, if you enable
DEBUG
and re-create the container you will see the output of the drives that are "visible" to homepage, e.g.:It is the
mount
property that homepage matches against.Additionally now, drives that aren't found will show:
Type of change
Checklist: