Skip to content

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jul 23, 2019

Closes #3222

What has been done to verify that this works as intended?

I tested the steps described in the issue.

Why is this the best possible solution? Were any other approaches considered?

It is just a simple fix. In FormChooserList we can use both MAX(date) and date columns depending on settings. My fix just handles the case where we use the simple date because the Hide old form versions option is disabled.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It is a safe solution which just fixes the bug and doesn't change anything else. Reproducing the issue and confirming the fix works fine would be enough.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel added this to the v1.23 milestone Jul 24, 2019
@mmarciniak90
Copy link
Contributor

Tested with success

Go to General Settings -> Form management and unselect Hide old form versions option.
Click on Fill Blank Form from the main menu.

Grzegorz's repro steps allowed me to reproduce the crash on all available devices.
The bug is not visible on apk with this fix.

Verified on Android: 4.2, 4.4, 5.1, 6.0, 7.0, 8.1

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"

@lognaturel lognaturel merged commit b33ca61 into getodk:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column 'MAX(date)' does not exist
4 participants