Skip to content

Organizations: Allow cross-account access #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 28, 2024

Conversation

viren-nadkarni
Copy link
Contributor

@viren-nadkarni viren-nadkarni commented Oct 25, 2024

This PR unlocks cross-account support for AWS Organizations.

After creating an organization and adding a member account to it, it is now possible to retrieve the details of the parent organization using DescribeOrganization from the member account.

Plus:

  • Calling CloseAccount on an already closed account raises
  • Calling RemoveAccountFromOrganization on an account which does not belong to any raises

A similar pattern was employed for S3 in #6333

@viren-nadkarni viren-nadkarni force-pushed the organizations-multi-accounts branch from 030aa53 to debbec5 Compare October 25, 2024 14:11
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (191ebcc) to head (519e20d).
Report is 156 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8260      +/-   ##
==========================================
+ Coverage   94.43%   94.55%   +0.12%     
==========================================
  Files        1139     1158      +19     
  Lines       97355   100384    +3029     
==========================================
+ Hits        91935    94922    +2987     
- Misses       5420     5462      +42     
Flag Coverage Δ
servertests 28.89% <36.00%> (-0.03%) ⬇️
unittests 94.53% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review October 28, 2024 08:26
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @viren-nadkarni!

@bblommers bblommers added this to the 5.0.18 milestone Oct 28, 2024
@bblommers bblommers merged commit 103f57a into getmoto:master Oct 28, 2024
53 checks passed
@viren-nadkarni viren-nadkarni deleted the organizations-multi-accounts branch October 28, 2024 09:39
@bblommers bblommers modified the milestones: 5.0.18, 5.0.19 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants