ACM-PCA: Add SAN extension passthrough from CSR #8894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e784ead to
b9eba3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8894 +/- ##
==========================================
- Coverage 94.56% 92.85% -1.71%
==========================================
Files 1158 1282 +124
Lines 100579 111879 +11300
==========================================
+ Hits 95109 103887 +8778
- Misses 5470 7992 +2522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bblommers
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Subject Alternative Name (SAN) passthrough from Certificate Signing Request (CSR) to the generated certificate. This allows the user to request any SAN extension: RFC822, Directory, URI etc.
This also fixes a misconfiguration in certificate generation where the DNS SAN extension was added if CN was set. In fact, the correct approach is to pass-through SAN extensions as set in the CSR. This is true for all templates (we don't support the API pass-through i.e. the
ApiPassthroughparameter)