Skip to content

feat (acm-pca): implement ListCertificateAuthorities API #8856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025

Conversation

HarshCasper
Copy link
Contributor

This PR implements the ListCertificateAuthorities API for the ACM-PCA provider.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.85%. Comparing base (8f08d11) to head (39138eb).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
moto/acmpca/models.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8856   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files        1281     1281           
  Lines      111640   111661   +21     
=======================================
+ Hits       103658   103678   +20     
- Misses       7982     7983    +1     
Flag Coverage Δ
servertests 27.98% <19.04%> (-0.01%) ⬇️
unittests 92.82% <95.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bblommers bblommers added this to the 5.1.5 milestone May 1, 2025
@bblommers bblommers merged commit 9e70500 into getmoto:master May 1, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants