ELB: Port and protocol validations for create listener #8563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5f7d0d to
eb3c105
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8563 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 1231 1231
Lines 106822 106851 +29
=======================================
+ Hits 98976 99005 +29
Misses 7846 7846
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9b02b70 to
4d69a5a
Compare
4d69a5a to
25d9703
Compare
bblommers
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Great tests @nik-localstack - always good to check every single scenario.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a listener, port and protocol should satisfy some conditions base on the load balancer type.
https://docs.aws.amazon.com/cli/latest/reference/elbv2/create-listener.html#options