Skip to content

EC2: Require size/snapshot when creating EBS volume #8556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nik-localstack
Copy link
Contributor

@nik-localstack nik-localstack force-pushed the fix/ec2/size-is-required-for-create-volume branch from 1efcd57 to 40a2567 Compare February 3, 2025 11:32
@nik-localstack nik-localstack marked this pull request as ready for review February 3, 2025 11:34
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (0238abd) to head (40a2567).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8556   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files        1229     1229           
  Lines      106421   106423    +2     
=======================================
+ Hits        98576    98578    +2     
  Misses       7845     7845           
Flag Coverage Δ
servertests 27.92% <50.00%> (+<0.01%) ⬆️
unittests 92.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers added this to the 5.0.29 milestone Feb 4, 2025
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @nik-localstack!

@bblommers bblommers merged commit 5abecce into getmoto:master Feb 4, 2025
54 checks passed
nik-localstack added a commit to localstack/localstack that referenced this pull request Feb 4, 2025
To be merged after moto v5.0.29 is merged into moto-ext
Related moto changes getmoto/moto#8556
nik-localstack added a commit to localstack/localstack that referenced this pull request Feb 21, 2025
To be merged after moto v5.0.29 is merged into moto-ext
Related moto changes getmoto/moto#8556
nik-localstack added a commit to localstack/localstack that referenced this pull request Feb 21, 2025
To be merged after moto v5.0.29 is merged into moto-ext
Related moto changes getmoto/moto#8556
@bblommers bblommers modified the milestones: 5.0.29, 5.1.0 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants