media-libs/lib3mf: Fix compilation on GCC 15 #38030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests pass - Patched file is not an installed header Note: Upstream PR fixes an additional file that does not error on 2.2.0 Upstream: 3MFConsortium/lib3mf#387 Closes: https://bugs.gentoo.org/937423 Signed-off-by: Christopher Fore <csfore@posteo.net>
Pull Request assignmentSubmitter: @csfore media-libs/lib3mf: @negril, @gentoo/proxy-maint Linked bugsBugs linked: 937423 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
thesamesam
reviewed
Aug 9, 2024
| @@ -0,0 +1,13 @@ | |||
| diff --git a/Source/Common/Platform/NMR_ImportStream_Unique_Memory.cpp b/Source/Common/Platform/NMR_ImportStream_Unique_Memory.cpp | |||
There was a problem hiding this comment.
In future, include the Gentoo bug link + PR link in the patch itself at the top as well in case other distros pick it up, so they have provenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Upstream PR fixes an additional file that does not error on 2.2.0
Upstream: 3MFConsortium/lib3mf#387
Closes: https://bugs.gentoo.org/937423
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.