dev-util/android-tools: Add patch to fix compilation on GCC 14 #34201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<algorithm> is no longer included by default in GCC 14 so explicitly including it is now required. Upstream: nmeum/android-tools#129 AOSP CR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578 AOSP CR: https://android-review.googlesource.com/c/platform/system/core/+/2839495 Both CRs to AOSP have been merged and upstream has merged the PR as well, all that is needed is a version bump from AOSP. Closes: https://bugs.gentoo.org/916788 Signed-off-by: Christopher Fore <csfore@posteo.net>
Pull Request assignmentSubmitter: @csfore dev-util/android-tools: @zmedico Linked bugsBugs linked: 916788 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
|
Thanks! |
Pull request CI reportReport generated at: 2023-12-09 21:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is no longer included by default in GCC 14 so explicitly including it is now required.
Upstream: nmeum/android-tools#129
AOSP CR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2838578
AOSP CR: https://android-review.googlesource.com/c/platform/system/core/+/2839495
Both CRs to AOSP have been merged and upstream has merged the PR as well, all that is needed is a version bump from AOSP.
Closes: https://bugs.gentoo.org/916788