fix: use tooltip to hides table content that exceeds the table length #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seven <zilisheng1996@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of overflowing table content by enabling tooltip display when content exceeds the table length.
- Added ellipsis configurations with tooltip support for the "aliases", "index_patterns", and "composed_of" columns.
- Updated icon properties in the "aliases" column, modifying icon placement and size for improved UI consistency.
Comments suppressed due to low confidence (3)
src/views/manage/components/index-manage.vue:196
- Ensure that the added ellipsis tooltip configuration for the 'aliases' column integrates well with existing styling and does not introduce conflicts with other render properties.
ellipsis: { tooltip: true },
src/views/manage/components/index-manage.vue:205
- [nitpick] The update from 'iconPlacement: "right"' with a style adjustment to 'size: "small"' and 'iconPlacement: "left"' changes the UI layout; please confirm that this shift aligns with the design requirements and overall UI consistency.
size: 'small',
src/views/manage/components/index-manage.vue:335
- [nitpick] Verify that the tooltip ellipsis behavior for the 'composed_of' column is consistent with how it is implemented in other similar table columns and meets the intended user interaction.
ellipsis: { tooltip: true },
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 52.77% 52.77%
=======================================
Files 10 10
Lines 108 108
Branches 14 14
=======================================
Hits 57 57
Misses 49 49
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: use tooltip to hides table content that exceeds the table length
Refs: #184