-
Notifications
You must be signed in to change notification settings - Fork 159
added apt-get for some reqs in ubuntu #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I remember when I first tried to compile gearmand and figuring out what packages needed to be installed was annoyingly not documented, so I'm sympathetic, but I feel the Dockerfiles in PR #327 is a better solution to this problem, overall. The Dockerfile for Ubuntu in that PR contains a packages list that is more complete, and there are Dockerfiles for other Linux distributions as well. |
Also, why |
Not at all, I just didn't know the generic name. I'm all in favour of using the better information that is stored in the docker file, but since I'm totally not going to use docker, and those only exist in PR form, I have added the extra repos and replaced the specific boost reference. Dealers choice as to whether it's worth putting in the README. libtokyocabinet-dev and tcsh are not strictly build requirements, but I left them in. |
OK, this is looking better. Thanks. Please remove tcsh and wget from the list. Wget is used to download the source code when building the Docker image, but it's not required when building from source when you already have the source code. And tcsh is not required to build either. I should probably remove it from the Dockerfiles. I just included it in my Docker images because I'm (very) old school and prefer it as my shell. 😄 |
Also, I think maybe you should just replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks so much for the contribution! Can you move this to docs/source/build/ubuntu.rst and instead if you could reference that directory in the README that would be ideal so that we make space for any build env.
Ubuntu 20.04 changed to Ubuntu and tcsh and wget removed from packages. With respect, moving the information to a seperate file would not be adventageous at this point. Also, people using debian or pretty much any other packaging system can derive the needed packages from that list. |
No description provided.