Skip to content

Conversation

sfinktah
Copy link
Contributor

No description provided.

@esabol
Copy link
Member

esabol commented Sep 19, 2022

I remember when I first tried to compile gearmand and figuring out what packages needed to be installed was annoyingly not documented, so I'm sympathetic, but I feel the Dockerfiles in PR #327 is a better solution to this problem, overall. The Dockerfile for Ubuntu in that PR contains a packages list that is more complete, and there are Dockerfiles for other Linux distributions as well.

@esabol
Copy link
Member

esabol commented Sep 19, 2022

Also, why libboost1.71-all-dev and not libboost-all-dev? Did they make some kind of incompatible change that we're not aware of?

@sfinktah
Copy link
Contributor Author

sfinktah commented Sep 23, 2022

Also, why libboost1.71-all-dev and not libboost-all-dev? Did they make some kind of incompatible change that we're not aware of?

Not at all, I just didn't know the generic name. I'm all in favour of using the better information that is stored in the docker file, but since I'm totally not going to use docker, and those only exist in PR form, I have added the extra repos and replaced the specific boost reference. Dealers choice as to whether it's worth putting in the README. libtokyocabinet-dev and tcsh are not strictly build requirements, but I left them in.

@esabol
Copy link
Member

esabol commented Sep 23, 2022

OK, this is looking better. Thanks. Please remove tcsh and wget from the list. Wget is used to download the source code when building the Docker image, but it's not required when building from source when you already have the source code. And tcsh is not required to build either. I should probably remove it from the Dockerfiles. I just included it in my Docker images because I'm (very) old school and prefer it as my shell. 😄

@esabol
Copy link
Member

esabol commented Sep 23, 2022

Also, I think maybe you should just replace satisfied on Ubuntu 20.04 with satisfied on Ubuntu because I'm pretty sure that list is the same for any version of Ubuntu going back to 16 at least and it'll probably (hopefully) work with future versions of Ubuntu, too.

Copy link
Member

@SpamapS SpamapS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks so much for the contribution! Can you move this to docs/source/build/ubuntu.rst and instead if you could reference that directory in the README that would be ideal so that we make space for any build env.

@sfinktah
Copy link
Contributor Author

@esabol

Ubuntu 20.04 changed to Ubuntu and tcsh and wget removed from packages.

@SpamapS

With respect, moving the information to a seperate file would not be adventageous at this point. Also, people using debian or pretty much any other packaging system can derive the needed packages from that list.

@esabol esabol merged commit d780729 into gearman:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants