Skip to content

Conversation

gitHusband
Copy link
Contributor

When I run gearmand -v, I got an error:

gearmand: unrecognised option '-v'

I think that should be changed to 'gearmand -d'

Copy link
Collaborator

@p-alik p-alik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But personally I would prefer to remove -d because it's optional.

@gitHusband
Copy link
Contributor Author

Ok, I'll close the pull request

@gitHusband gitHusband closed this Sep 1, 2020
@p-alik p-alik reopened this Sep 1, 2020
@p-alik
Copy link
Collaborator

p-alik commented Sep 1, 2020

@gitHusband, wait a bit please!

@esabol
Copy link
Member

esabol commented Sep 1, 2020

-v was deprecated in January, 2012. It’s hard to believe this has been wrong for so many years!

The next paragraph says, “This will start it while printing some verbose messages.” Therefore, I think what we want here is gearmand --verbose INFO. @gitHusband: Would you make that change please?

I have no objection to keeping the -d here. That could be useful.

@gitHusband
Copy link
Contributor Author

@esabol Yeah, my pleasure! Changed to gearmand --verbose INFO now.

@esabol
Copy link
Member

esabol commented Sep 2, 2020

LGTM. @p-alik: Do you approve?

@esabol esabol merged commit e4aa993 into gearman:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants