Skip to content

Conversation

ntrel
Copy link
Member

@ntrel ntrel commented Aug 17, 2019

Fixes #2261.

@ntrel ntrel marked this pull request as ready for review August 17, 2019 11:30
Copy link
Member

@codebrainz codebrainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK by inspection.

@b4n
Copy link
Member

b4n commented Aug 24, 2019

Is this still relevant? Looking at the conversation in #2261 it's kind of unclear.
However, this looks good anyhow.

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and safe

@kugel-
Copy link
Member

kugel- commented Sep 20, 2019

Should probably merge this for 1.36?

@elextr
Copy link
Member

elextr commented Sep 21, 2019

Two approvals is enough for me.

@elextr elextr merged commit 411aa99 into geany:master Sep 21, 2019
lpaulsen93 pushed a commit to lpaulsen93/geany that referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] MSYS2 causes realpath to be redeclared in tm_source_file.c
5 participants