Skip to content

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Jun 10, 2019

Also update keywords for the NSIS filetype and add a script to do the update work for us.

Closes #1302.

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the 2 comments that I'm sure are nothing, I have nothing else to say, as I don't know much of it and trust you on this :)

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment, LGTM

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking below, otherwise looks good 👍

And add a script to make this task easier in the future.
@eht16 eht16 merged commit aa54866 into geany:master Jul 6, 2019
@eht16 eht16 deleted the nsis_upgrade branch July 6, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Windows installer to NSIS 3.x
2 participants