-
Notifications
You must be signed in to change notification settings - Fork 632
NSIS upgrade to 3.x #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSIS upgrade to 3.x #2181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the 2 comments that I'm sure are nothing, I have nothing else to say, as I don't know much of it and trust you on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the one comment, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking below, otherwise looks good 👍
And add a script to make this task easier in the future.
Also update keywords for the NSIS filetype and add a script to do the update work for us.
Closes #1302.