-
Notifications
You must be signed in to change notification settings - Fork 632
TypeScript syntax highlighting #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This could probably go on the wiki with the other filetype configurations here |
Why not just make it built-in? The vast majority of users will not be searching for syntax highlighting - I didn't even know it was possible to make a custom filetype until I ran into this. |
No typescriptists willing to test? |
I tried out the changes here and they work fine for me. |
Please, how can i install this TypeScript syntax highlighting in Geany? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providing this works for enough TypeScript code, I think we should merge this.
@jhpratt It would be good to resolve my review points though.
[keywords] | ||
# all items must be in one line | ||
primary=break case catch class const continue debugger default delete do else enum export extends extend false finally for function get if import in Infinity instanceof let NaN new null return set static super switch this throw true try typeof undefined var let while with yield prototype async await declare aliased interfaced Alias Interface interface | ||
secondary=Array Boolean boolean Date Function Math Number number Object String string RegExp EvalError Error RangeError ReferenceError SyntaxError TypeError URIError constructor prototype decodeURI decodeURIComponent encodeURI encodeURIComponent eval isFinite isNaN parseFloat parseInt protected public private keyof void any never readonly as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each of these keyword lists are not sorted properly. I'm not sure if Scintilla requires sorted lists for correct operation.
# %e will be replaced by the filename without extension | ||
# (use only one of it at one time) | ||
#FT_02_LB=_Lint | ||
#FT_02_CM=jshint "%f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there no commands to compile/check a typescript file has valid syntax?
@@ -0,0 +1,54 @@ | |||
# based on JavaScript file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be listed in data/Makefile.am
.
@jhpratt Plus resolve the conflict please if possible. Thanks for submitting this BTW. @marcooliva Download the |
@ntrel I've long since moved on from Geany. I find VS Code far superior. It's been a couple years since I submitted this PR, so a good number of changes may be out of date as well. If you'd like this conflict resolved, you should be able to edit the PR. If not, feel free to use my changes at your discretion. |
implemented in #2187 |
#1449
I probably missed something, but it just adds in a few keywords from JS.