-
-
Notifications
You must be signed in to change notification settings - Fork 243
implement alias support #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for PR! Will review in upcoming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR!
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
Hi, please rebase your PR on fresh master. It has reworked chain interface. Instead of: r.chain.enter("XXX()")
defer r.leave()
if r.failed() {
return r
} we should now use: opChain := r.chain.enter("Decode()")
defer opChain.leave()
if opChain.failed() {
return r
} In other words, chain.enter() now returns a new chain instance, and we should use it for all other operations with chain. This change is part of making this lib thread-safe. Related commits: |
The following changes in chain affect this PR:
|
Sorry for creating conflicts. I was waiting with my changes for a while, in hope that I'll find a time window when there are no active PRs and I can merge them without creating conflicts. However it seems that currently new PRs are coming too often and there is no such window :) |
a8d352a
to
b9b52d4
Compare
b9b52d4
to
534ab72
Compare
@gavv I rebased and fixed, so please check when you have time. Thank you. |
Thank you! Solid work! |
close #171