Skip to content

Add example oauth2 and InList/NotInList #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 4, 2023
Merged

Add example oauth2 and InList/NotInList #267

merged 9 commits into from
Feb 4, 2023

Conversation

fahimbagar
Copy link
Contributor

This PR does the following:

  • Add new example for InList and NotInList inside fruits.go
  • Add new example for oauth2
  • Update README.md

Closes #250 and #251

@coveralls
Copy link
Collaborator

coveralls commented Feb 1, 2023 •
edited
Loading

Coverage Status

Coverage: 94.903%. Remained the same when pulling ebc2b1b on fahimbagar:add-example into c1e0a61 on gavv:master.

@fahimbagar fahimbagar mentioned this pull request Feb 1, 2023
Closed
@gavv gavv added the ready for review Pull request can be reviewed label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts.

@github-actions github-actions bot added the needs rebase Pull request has conflicts and should be rebased label Feb 2, 2023
@gavv
Copy link
Owner

gavv commented Feb 2, 2023

Sorry, seems my recent commit created conflict. Could you please rebase on fresh master?

@fahimbagar
Copy link
Contributor Author

It's done, @gavv.

@gavv gavv removed the needs rebase Pull request has conflicts and should be rebased label Feb 3, 2023
gavv
gavv reviewed Feb 3, 2023
View reviewed changes
Copy link
Owner

@gavv gavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! Here are a few comments.

@gavv gavv added needs revision Pull request should be revised by its author and removed ready for review Pull request can be reviewed labels Feb 3, 2023
@fahimbagar fahimbagar requested a review from gavv February 3, 2023 20:02
@gavv gavv added ready for review Pull request can be reviewed and removed needs revision Pull request should be revised by its author labels Feb 4, 2023
@gavv gavv force-pushed the master branch 4 times, most recently from 5fc5b9c to d159043 Compare February 4, 2023 11:21
@gavv gavv merged commit e4d129c into gavv:master Feb 4, 2023
@gavv
Copy link
Owner

gavv commented Feb 4, 2023

Thank you!

@gavv
Copy link
Owner

gavv commented Feb 4, 2023

Follow-up commit: f29b995

  • don't access client store from test; the only things shared between server and test are strings for client id and secret
  • use hard-coded strings for simplicity
  • cosmetic fixes

@gavv gavv removed the ready for review Pull request can be reviewed label Feb 4, 2023
@fahimbagar fahimbagar deleted the add-example branch February 4, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv Awaiting requested review from gavv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement InList and NotInList methods
3 participants
@fahimbagar @coveralls @gavv