Skip to content

Add NamespacedCloudProfile validation and mutation webhooks #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add NamespacedCloudProfile validation and mutation webhooks #918

merged 2 commits into from
Dec 6, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area usability
/kind enhancement
/platform gcp

What this PR does / why we need it:
Support custom machine images and versions in NamespacedCloudProfiles. For that, add mutating and validating admission webhooks.

Which issue(s) this PR fixes:
Part of gardener/gardener#9504, followup to gardener/gardener#10629.

Special notes for your reviewer:

Release note:

Add `NamespacedCloudProfile` admission mutation and validation to support custom machine images and types.

@LucaBernstein LucaBernstein requested review from a team as code owners December 6, 2024 14:03
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure labels Dec 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2024
@LucaBernstein LucaBernstein mentioned this pull request Dec 6, 2024
Open
45 tasks
AndreasBurger
AndreasBurger approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndreasBurger AndreasBurger merged commit 69fa4d8 into gardener:master Dec 6, 2024
17 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 6, 2024
@LucaBernstein LucaBernstein deleted the nscpfl/10629/namespacedcloudprofile-providerConfig branch December 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/gcp Google cloud platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaBernstein @AndreasBurger @gardener-robot-ci-2 @gardener-robot